Skip to content

Conversation

@Remi-Gau
Copy link
Contributor

@Remi-Gau Remi-Gau commented Mar 6, 2021

To avoid cluttering the working directory.

  • options for a given analysis are saved in a cfg folder in the working directory
  • load and check will also check for options to load in this foled
  • move options*.json files of the demos into cfg folders
  • update tests

@Remi-Gau
Copy link
Contributor Author

Remi-Gau commented Mar 6, 2021

fixes #301

@Remi-Gau Remi-Gau linked an issue Mar 6, 2021 that may be closed by this pull request
@codecov
Copy link

codecov bot commented Mar 6, 2021

Codecov Report

Merging #308 (a7be094) into dev (c3511c7) will decrease coverage by 0.07%.
The diff coverage is 25.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##              dev     #308      +/-   ##
==========================================
- Coverage   62.66%   62.58%   -0.08%     
==========================================
  Files         108      108              
  Lines        1714     1716       +2     
==========================================
  Hits         1074     1074              
- Misses        640      642       +2     
Impacted Files Coverage Δ
src/utils/saveOptions.m 0.00% <0.00%> (ø)
src/utils/loadAndCheckOptions.m 95.45% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c3511c7...a7be094. Read the comment docs.

@Remi-Gau Remi-Gau merged commit 84e7fc5 into cpp-lln-lab:dev Mar 10, 2021
@Remi-Gau Remi-Gau deleted the remi-save_options+ branch March 10, 2021 14:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Save those freaking options*.json files in a subfolder. 😉

1 participant