[WIP] constrast specification + uni and multivaraite issues + remove dummies #51
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit 01e95eb.
change model.Steps(iStep) to model.Steps{iStep}
- Contrasts are computed for every event in each run. - Model.json files contains the information for computing the contrasts (autocontrasts) from the level:Run
This reverts commit 01e95eb.
change model.Steps(iStep) to model.Steps{iStep}
- Contrasts are computed for every event in each run. - Model.json files contains the information for computing the contrasts (autocontrasts) from the level:Run
- remove dead code - add help section - improve human readability
- makes the use of leading zeros obsolete
Contributor
Author
|
Main change added:
Minor changes:
|
- use input file validation - use absolute paths - simplify file deletion - only delete beta / T / con maps that have been used
Contributor
Author
|
OK I have tested this on a couple of data sets and it seems OK: this should be good for one final review. @mohmdrezk most of the changes are in :
see also message above. note to self: next time let's make smaller pull requests with fewer features in them and starting from a recent version of master. |
Contributor
Author
|
One thing I will do once this is merged is to double check how it runs on octave and docker |
- fix subNumber in copyRawFolder
- pmCon: fix model.Steps(iStep) to model.Steps{iStep}
…nstrast-specification
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Opening a PR to make sure that all the tests will pass and prepare for merging.