Skip to content

Conversation

@Remi-Gau
Copy link
Contributor

This a small addition to get the results of a given contrasts via scripting instead of via the GUI.

This also allows the implementation of exporting results using the NIDM format that greatly facilitates uploading results to neurovault.

This refers to issue #52

@Remi-Gau Remi-Gau requested a review from mohmdrezk November 12, 2019 23:39
@@ -0,0 +1,37 @@
function test_modelFiles()
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a very ugly test but it might let us know when we get some weird failure when the json model files are not properly formated


spm_jobman('run',matlabbatch)

% move ps file
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ideally we might want to rename each file that is created to make it easier to know which one is which when uploading to neurovault.

getOption.m Outdated
% opt.taskName = 'visMotion';

% opt.taskName = 'balloonanalogrisktask';
opt.taskName = 'balloonanalogrisktask';
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should I move all the information related to this dataset (ds001 on open neuro) out of getOption and use that to replace the current getOption template we have?

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it doesnt really matter. Any example that is avaialbe is good for the new user, and they will always have to change the taskName anyway.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OK I will update the template then.

@Remi-Gau
Copy link
Contributor Author

One thing we might want to do is to check to clean the getOption file to make it easier to read for the workshop as now it has a lot of commented part that are cluttering the readability.

@@ -0,0 +1,142 @@
function BIDS_Results(FFXSmoothing, ConSmoothing, opt, isMVPA)
% This scripts computes the results for a series of contrast that can be
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

How is that different from the FFX or RFX script which should compute the same thing?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry the help section is really unhelpful here: this script actually does all the stuff that the user one would need to do when clicking Results on the GUI interface.
The other nice thing is that this allows to easily display the same results for all subjects of group rather than having to do that by hand.

@Remi-Gau Remi-Gau merged commit a1c737d into cpp-lln-lab:master Nov 13, 2019
@Remi-Gau Remi-Gau deleted the remi-results branch September 26, 2020 12:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants