Skip to content

Conversation

@Remi-Gau
Copy link
Contributor

@Remi-Gau Remi-Gau commented Sep 17, 2020

Could be used as an MT / MST "localizers"

What to review

  • does it MT / MST localizer run?
  • does the regular visual localizer still run?
  • any suggestion for improvement?

REFACTOR (later)

Can be used as is but ideally we will want to refactor (I guess later after merging):

  • setParameters (too many if statements)
  • expDesign (we have one for regular localizer and one of MT / MST eventhough 90% are the same)

TO DO (later)

@codecov
Copy link

codecov bot commented Sep 17, 2020

Codecov Report

Merging #52 into dev will not change coverage.
The diff coverage is 0.00%.

Impacted file tree graph

@@          Coverage Diff          @@
##             dev     #52   +/-   ##
=====================================
  Coverage   0.00%   0.00%           
=====================================
  Files          4      11    +7     
  Lines        134     169   +35     
=====================================
- Misses       134     169   +35     
Flag Coverage Δ
#unittests 0.00% <0.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
subfun/assignConditions.m 0.00% <0.00%> (ø)
subfun/diplayDesign.m 0.00% <0.00%> (ø)
subfun/doDotMo.m 0.00% <0.00%> (ø)
subfun/expDesign.m 0.00% <0.00%> (ø)
subfun/getDesignInput.m 0.00% <0.00%> (ø)
subfun/getDirectionBaseVectors.m 0.00% <0.00%> (ø)
subfun/postInitializationSetup.m 0.00% <0.00%> (ø)
subfun/preSaveSetup.m 0.00% <0.00%> (ø)
subfun/preTrialSetup.m 0.00% <0.00%> (ø)
subfun/saveResponsesAndTriggers.m 0.00% <ø> (ø)
... and 8 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c854e6f...db8c02b. Read the comment docs.

@Remi-Gau
Copy link
Contributor Author

@marco as I was doing some refactoring this should fix #42

@Remi-Gau Remi-Gau merged commit 2304925 into cpp-lln-lab:dev Sep 23, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant