MT / MST ready

[Remi-Gau]

very few changes in the repo itself but a lot actually happened in the CPP_PTB submodule.

@marco can I let you test it to make sure it runs fine?

I still need to refactor the setParameters to have all the stuff related to the MT / MST will be in the same spot.

[codecov]

Codecov Report

Merging #59 into dev will not change coverage.
The diff coverage is 0.00%.

@@          Coverage Diff          @@
##             dev     #59   +/-   ##
=====================================
  Coverage   0.00%   0.00%           
=====================================
  Files         11      11           
  Lines        169     173    +4     
=====================================
- Misses       169     173    +4     

Flag	Coverage Δ
#unittests	0.00% <0.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files	Coverage Δ
subfun/doDotMo.m	0.00% <0.00%> (ø)
subfun/preTrialSetup.m	0.00% <0.00%> (ø)

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9454d50...f16bcff. Read the comment docs.

[marcobarilari]

Run 1 time and giving here the first impression:

• very nice 👍

• the red cross stays up for a long time

• in the command window I don't see printed the events happening

TBC

[marcobarilari]

Now our localizer can do a lot of stuff and it is great, docs will need to explain all its different capabilities and how to implement them.

Let me know if I can help refactoring the setParameters func, after that I think it's ready

[Remi-Gau]

• compare to old version from Moh's

[Remi-Gau]

fixes #64

[marcobarilari]

LGTM!

Only one last thing, unless I missed something in the MRI we will present the MT loc on the whole screen so we don't care to 'rescale' to the size of the actual subject view on the mirror.

Will we need to tweak something to present the MT_MTS loc in a smaller central portion of the screen?

(if changes are needed we can do it in a different PR, if I remember well initPTB can handle this thing and I can take care of it)

[Remi-Gau]

LGTM!

Only one last thing, unless I missed something in the MRI we will present the MT loc on the whole screen so we don't care to 'rescale' to the size of the actual subject view on the mirror.

Will we need to tweak something to present the MT_MTS loc in a smaller central portion of the screen?

(if changes are needed we can do it in a different PR, if I remember well initPTB can handle this thing and I can take care of it)

Yes let's do that in another PR. I need to get this one off my chest. :-)

[marcobarilari]

ready to be merged