Update "libuv"

[Thalhammer]

• I'm interested in package libuv

Its already part of hunter but in a pretty old version (1.23) and not the current version 1.42 (release ~3 months ago).
Given the disaster (#467 ) of the last time I tried to add a package here, I instead resort to asking nicely this time.
Would it be possible to update libuv to a current version ?

[NeroBurner]

No disaster, a learning experince :)

PR is very much welcome

[Thalhammer]

I forked and updated hunter-packages/libuv to the current version, but I can't do a PR cause the branch doesn't exist in the repo.
https://github.com/Thalhammer/libuv/tree/hunter-1.42.0 (Ignore the ci, it fails cause they explicitly specify the test binary name, it compiles and tests fine)

I think I replicated the changes ruslo did good enough. To go further (doing a update in hunter itself) it would be good to merge and release the version there first so I can directly punch the correct release url into the pr for hunter.

[rbsheth]

@Thalhammer No worries, like @NeroBurner it was a learning experience. 😄

You should push the base version branch directly from the upstream commit. For example, if you want version 1.42.0 you can push hunter-1.42.0 directly to the cpp-pm fork. The hunter-packages forks are old/supposed to be read-only. Use this fork instead https://github.com/cpp-pm/libuv

After you push the base changes, your Hunterization commits should be made into a PR on top, with hunter-1.42.0 as the target branch.

[Thalhammer]

@rbsheth Maybe I am not getting what you mean, but I don't have permission to push to cpp-pm/libuv.
The branch I made above is based on the official libuv tag with a single hunterize commit on top.

[rbsheth]

You should have received an invite to @cpp-pm/cpp-pm-packages. Once you accept it, you can update the libuv fork.

[Thalhammer]

Ah right, didn't see it, but I got an email.
I pushed upstream, forked the project, carried over my changes to the new fork and did a pull request.

cpp-pm/libuv#1

[rbsheth]

Closed by #482