Skip to content

Conversation

@Leviathes
Copy link

Just a few changes to make this section easier to comprehend. A few things were only technically wrong (using singulars instead of plurals or vice/versa). Changed the wording of some things to make the intent clearer.

  • I've followed this guide
    step by step carefully. [Yes|No]

  • I've followed this guide
    step by step carefully. [Yes|No]
  • This update will break a few toolchains.
    • Toolchain 1
    • Toolchain 2
  • This update will fix a few toolchains.
    • Toolchain 1
    • Toolchain 2

  • I've checked this Git style guide. [Yes|No]
  • I've checked this CMake style guide. [Yes|No]
  • My change will work with CMake 3.2 (minimum requirement for Hunter). [Yes|No]
  • I will try to keep this pull request as small as possible and will try not to mix unrelated features. [Yes|No]

Just a few changes to make this section easier to comprehend. A few things were only technically wrong (using singulars instead of plurals or vice/versa). Changed the wording of some things to make the intent clearer.
Copy link
Member

@rbsheth rbsheth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@rbsheth rbsheth merged commit 8087b9f into cpp-pm:master Oct 13, 2021
@rbsheth
Copy link
Member

rbsheth commented Oct 27, 2021

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants