Skip to content

Conversation

@ned14
Copy link

@ned14 ned14 commented Dec 6, 2021

  • I've followed this guide
    step by step carefully. Yes

@ned14
Copy link
Author

ned14 commented Dec 6, 2021

Re: the /analyze failure, I will report it upstream if it repros on their trunk, but I'm unsure what to do with this release?

@ned14
Copy link
Author

ned14 commented Dec 7, 2021

@rbsheth What would you prefer I do re the analyse failure above? Note we're using the zstd 1.5.0 release directly, no local fork.

@rbsheth
Copy link
Member

rbsheth commented Dec 7, 2021

@rbsheth What would you prefer I do re the analyse failure above? Note we're using the zstd 1.5.0 release directly, no local fork.

Typically, we don't care too much about the analyze failure.

@rbsheth rbsheth merged commit 14a6b9a into cpp-pm:master Dec 7, 2021
@ned14 ned14 deleted the pr/zstd-1.5.0 branch December 7, 2021 21:11
@rbsheth
Copy link
Member

rbsheth commented Dec 15, 2021

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants