body_read_stream implementation - WORK IN PROGRESS

[MungoG]

Implementation for the body_read_stream part of #55

[vinniefalco]

you should be able to get away with just parser.hpp instead of these other two

[vinniefalco]

I don't think result.hpp is going to help?

[vinniefalco]

I don't think the context is needed

[MungoG]

Note to self: add get_executor()

[vinniefalco]

Maybe just Stream would suffice instead of UnderlyingAsyncReadStreamToUseForTheNextLayer?

[cppalliance-bot]

An automated preview of the documentation is available at https://57.http-io.prtest2.cppalliance.org/index.html

If more commits are pushed to the pull request, the docs will rebuild at the same URL.

2025-10-20 18:03:41 UTC

[cppalliance-bot]

An automated preview of the documentation is available at https://57.beast2.prtest3.cppalliance.org/index.html

If more commits are pushed to the pull request, the docs will rebuild at the same URL.

2025-10-22 09:45:21 UTC

[ashtum]

If this class needs to satisfy Asio's AsyncReadStream type requirements, then the async_read function is unnecessary.

[ashtum]

I believe the operation should make a copy of the provided buffer, otherwise, the call site must manage the buffer's lifetime, which is cumbersome and inconsistent with the Asio.
Like this could is UB currently:

brs.async_read_some(
    buf.prepare(buf.capacity()), // <--- would be destroyed after call
    [&](system::error_code ec, std::size_t n)
    {
    });

[ashtum]

@MungoG, now that we have test::stream available, we could simplify the unit test to something like this. I'm not sure how much of the existing source code it covers, but it should be a good starting point.

struct body_read_stream_test
{
    core::string_view const msg =
        "HTTP/1.1 200 OK\r\n"
        "Content-Length: 3\r\n"
        "\r\n"
        "abc";

public:
    void
    testAsyncReadSome()
    {
        boost::asio::io_context ioc;
        rts::context rts_ctx;
        http_proto::install_parser_service(rts_ctx, {});

        test::stream ts(ioc, msg);
        http_proto::response_parser pr(rts_ctx);
        pr.reset();
        pr.start();

        // limit async_read_some for better coverage
        ts.read_size(1);

        body_read_stream<test::stream> brs(ts, pr);

        char storage[8];
        buffers::flat_buffer buf(storage, sizeof(storage));

        // read 1 octet of body
        brs.async_read_some(
            buf.prepare(buf.capacity()),
            [&](system::error_code ec, std::size_t n)
            {
                BOOST_TEST(! ec.failed());
                BOOST_TEST_EQ(n, 1);
                buf.commit(n);
            });
        test::run(ioc);
        BOOST_TEST(pr.got_header());
        BOOST_TEST(! pr.is_complete());
        BOOST_TEST_EQ(
            buffers::size(pr.pull_body()), 0);

        // read the remaining body
        // asio::async_read repeatedly calls async_read_some
        // until all supplied buffers are filled, or an error occurs.
        asio::async_read(
            brs,
            buf.prepare(buf.capacity()),
            [&](system::error_code ec, std::size_t n)
            {
                BOOST_TEST_EQ(ec, asio::error::eof);
                BOOST_TEST_EQ(n, 2);
                buf.commit(n);
            });
        test::run(ioc);
        BOOST_TEST(pr.got_header());
        BOOST_TEST(pr.is_complete());
        // no body octets should remain
        BOOST_TEST_EQ(
            buffers::size(pr.pull_body()), 0);
        BOOST_TEST(
            core::string_view(
                static_cast<const char*>(buf.data().data()),
                buf.data().size()) == "abc");
    }

    void
    run()
    {
        testAsyncReadSome();
    }
};