Add read_from_single_buffer helper for ReadSource implementations #63
+200
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This helper function assists models of the ReadSource concept by handling iteration over a mutable buffer sequence and invoking a user-provided function for each buffer. The function integrates the results and properly handles error::eof. The implementation follows the pattern used in any_read_source::read() and provides special EOF handling: when EOF occurs after reading some bytes, it returns success with the byte count instead of propagating the EOF error. Fixes #59 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-authored-by: Vinnie Falco <vinniefalco@users.noreply.github.com>
vinniefalco
commented
Nov 30, 2025
|
|
||
| if(ec_tmp.failed()) | ||
| { | ||
| if(ec_tmp == error::eof && total > 0) |
Member
Author
There was a problem hiding this comment.
@claude
zero bytes and error::eof is ok, it can happen with empty files and empty content bodies
There was a problem hiding this comment.
Claude finished @vinniefalco's task —— View job
Acknowledgment
Understood! The current implementation correctly handles both cases:
- EOF with
total > 0: Returns success with the accumulated byte count (line 160-165) - EOF with
total == 0: Propagates the EOF error (line 166-168)
This allows empty files and empty content bodies to properly signal EOF on the first read with zero bytes, which is the expected behavior for these cases.
|
An automated preview of the documentation is available at https://63.buffers.prtest.cppalliance.org/index.html If more commits are pushed to the pull request, the docs will rebuild at the same URL. 2025-11-30 06:01:47 UTC |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This helper function assists models of the ReadSource concept by handling iteration over a mutable buffer sequence and invoking a user-provided function for each buffer.
The implementation follows the pattern used in
any_read_source::read()and provides special EOF handling: when EOF occurs after reading some bytes, it returns success with the byte count instead of propagating the EOF error.Fixes #59
Generated with Claude Code