Skip to content

Conversation

@mborland
Copy link
Member

Closes: #1107

@mborland mborland added this to the v6.0.0 milestone Oct 16, 2025
@mborland mborland self-assigned this Oct 16, 2025
@mborland mborland added Bug Something isn't working Boost Review Collected Comments from Boost Review Period labels Oct 16, 2025
@codecov
Copy link

codecov bot commented Oct 16, 2025

Codecov Report

❌ Patch coverage is 95.61404% with 10 lines in your changes missing coverage. Please review.
✅ Project coverage is 99.4%. Comparing base (ca6ef19) to head (7a30129).
⚠️ Report is 12 commits behind head on develop.

Files with missing lines Patch % Lines
include/boost/decimal/decimal_fast128_t.hpp 66.7% 8 Missing ⚠️
include/boost/decimal/decimal64_t.hpp 96.7% 2 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff            @@
##           develop   #1136     +/-   ##
=========================================
- Coverage     99.4%   99.4%   -0.0%     
=========================================
  Files          251     252      +1     
  Lines        17023   17164    +141     
  Branches      1834    1866     +32     
=========================================
+ Hits         16918   17048    +130     
- Misses         105     116     +11     
Files with missing lines Coverage Δ
include/boost/decimal/decimal128_t.hpp 98.6% <100.0%> (+0.1%) ⬆️
include/boost/decimal/decimal32_t.hpp 96.8% <100.0%> (+0.1%) ⬆️
include/boost/decimal/decimal_fast32_t.hpp 100.0% <100.0%> (ø)
include/boost/decimal/decimal_fast64_t.hpp 100.0% <100.0%> (ø)
include/boost/decimal/detail/comparison.hpp 99.5% <100.0%> (+0.1%) ⬆️
test/compare_dec128_and_fast.cpp 97.7% <100.0%> (-2.3%) ⬇️
test/github_issue_1106.cpp 100.0% <ø> (ø)
test/github_issue_1107.cpp 100.0% <100.0%> (ø)
test/random_decimal64_math.cpp 100.0% <ø> (ø)
test/random_mixed_decimal_math.cpp 100.0% <ø> (ø)
... and 3 more

... and 1 file with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ca6ef19...7a30129. Read the comment docs.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@mborland mborland merged commit 7cfb824 into develop Oct 16, 2025
74 checks passed
@mborland mborland deleted the 1107 branch October 16, 2025 12:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Boost Review Collected Comments from Boost Review Period Bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Decide if to handle -infinity + infinity addition correctly.

1 participant