This repository was archived by the owner on Jun 12, 2018. It is now read-only.
Cleanup of TranslationUnit and CodeCompleteResults. #23
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@zalox: hope you can look over and merge this soon. The main problem was a bit confusing constructors and methods, and the std::map that forced us to previously do a copy of the source buffer (which is expensive). This is fixed now.
Mind that only one unsaved buffer is used now when calling the libclang functions. I really do not see any case where sending several unsaved files to libclang is a good idea, at least we would never do that in juCi++. If this is needed anyway (highly doubtful), I suggest that we try find a better solution than std::map, in order to avoid copy.