[5.x]: Closing nested entry slideouts by clicking outside, scrolls to top of CKEditor field

[thupsi]

What happened?

Description

When editing a nested entry in a CKEditor field that is taller than the viewport, closing the slideout by clicking outside causes the page to scroll so that the top of the CKEditor field is visible.

Steps to reproduce

1. Edit a CKEditor field that is tall enough as not to fit in the viewport.
2. Add a nested entry to the bottom of the field.
3. Open the entry slideout
4. Close the slideout by clicking outside.

Expected behavior

The page scroll position does not change.

Actual behavior

The page scrolls so the top of the field is visible.

Craft CMS version

5.6.13

PHP version

No response

Operating system and version

No response

Database type and version

No response

Image driver and version

No response

Installed plugins and versions

[i-just]

Hi, thanks for getting in touch! I can only reproduce this if I’m in the process of adding a new nested entry to the CKE field and, before saving it, I leave the slideout. In that case, the card isn’t created, and it looks like the focus is returned to the toolbar button that triggered the slideout to open in the first place, which causes the page to scroll up. Is that what you’re seeing, or is the page scrolling up for you even when you open an existing nested element’s card?

Also, what browser & OS are you seeing this on?

[thupsi]

Hi, thanks for taking a look! I can indeed triger this even when opening an existing nested element's card. It seems like it has to do with the focus getting set on the content of the field. See recording below:

ckeditor_scroll.mp4

I'm on Windows, using Chrome.

[i-just]

Thanks for clarifying! I can reproduce in Chrome and Safari but not in Firefox (which is what I used to test in the first place).

[i-just]

I raised a PR for this. To test this early, you can require "craftcms/ckeditor": "4.x-dev#d796757b144e8e45be62421c4b95d36901890cf5 as 4.6.0" in your composer.json and run composer update.

[thupsi]

Seems to work as expected! Thanks!

[brandonkelly]

CKEditor 4.7.0 is out with that fix. Thanks again!