Handle auth for endpoints without service field #40
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ut 'service' field in bearer response header
MShekow
changed the title
crashvb
approved these changes
Aug 5, 2025
Owner
crashvb
left a comment
crashvb
left a comment
There was a problem hiding this comment.
Thanks for the patch; sorry for the delay
Owner
|
Released as v1.0.3 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR addresses #38
It's a simple workaround to avoid
KeyError: 'service'for registries such asmirror.gcr.iowhere theBearerin theWww-Authenticateresponse header lacks aservicefield.I suppose you might want to implement this differently/better. I needed a quick hack and couldn't wait for you to address #38 yourself.