Fixed handling of DuplicateKeyException errors after crate-python 0.34
#439
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
After an improvement in crate-python 0.34, this error case is conveyed through `IntegrityError`. Beforehand, a more generic `ProgrammingError` was used. Without the update, a duplicate key exception causes crash to exit prematurely and unexpectedly, when using more recent versions of crate-python. Now, both exception types will be handled in the same way.
amotl
force-pushed
the
amo/handle-integrity-error
branch
from
e639940
to
3306eff
Compare
seut
approved these changes
Apr 24, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
Thanks for reporting, @romseygeek and @proddata.
Details
After an improvement in crate-python 0.34, this error case is conveyed through
IntegrityError. Beforehand, a more genericProgrammingErrorwas used.Without the update, a duplicate key exception causes crash to exit prematurely and unexpectedly, when using more recent versions of crate-python.
Solution
Now, both exception types will be handled in the same way.