Skip to content

added missing functionality to cratedialect #115

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Feb 4, 2015
Merged

added missing functionality to cratedialect #115

merged 1 commit into from
Feb 4, 2015

Conversation

spanktar
Copy link
Contributor

@spanktar spanktar commented Feb 3, 2015

Add missing dialect attributes from initialize method.
Add tests for the same.

@chaudum chaudum changed the title https://github.com/crate/crate-python/issues/113 added missing functionality to cratedialect Feb 4, 2015
@coveralls
Copy link

Coverage Status

Coverage increased (+0.05%) to 95.98% when pulling 27f3eb4 on spanky/113 into ab0f35b on master.

@mfussenegger
Copy link
Member

changes are missing, otherwise ack

@coveralls
Copy link

Coverage Status

Coverage decreased (-0.07%) to 95.86% when pulling 0706261 on spanky/113 into ab0f35b on master.

@coveralls
Copy link

Coverage Status

Coverage increased (+0.05%) to 95.98% when pulling 0706261 on spanky/113 into ab0f35b on master.

@spanktar @chaudum
added missing functionality to CrateDialect
618b2cc 
Add missing dialect attributes from initialize method.
Add tests for the same.
@coveralls
Copy link

Coverage Status

Coverage increased (+0.05%) to 95.98% when pulling 0a4e3e8 on spanky/113 into ab0f35b on master.

@chaudum chaudum merged commit 618b2cc into master Feb 4, 2015
@chaudum chaudum deleted the spanky/113 branch February 4, 2015 13:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@spanktar @coveralls @mfussenegger @chaudum