SQLAlchemy/DDL: Allow to turn off column store #555
Conversation
|
Dear Matthias, thanks a stack for submitting this improvement to the DDL compiler. In order to make the patch complete, we will need to add software tests and documentation. Would you be up to add them, or do you want us to take over? With kind regards, |
amotl
changed the title
|
@amotl Thank you very much. I will add some tests and documentation - just not sure when, as I'm quite occupied at work lately. But as the changes are very minor, I think I will soon push some changes. |
|
@amotl I have added the tests and some (little) docs. If I got it right, columnstore can only be turned off for TEXT columns, hence I added this as a condition to the code. In case this needs some rework, please let me know. |
| if column.dialect_options['crate'].get('columnstore') is False: | ||
| if not isinstance(column.type, (String, )): | ||
| raise sa.exc.CompileError( | ||
| "Controlling the columnstore is only allowed for STRING columns" | ||
| ) | ||
|
|
||
| colspec += " STORAGE WITH (columnstore = false)" |
There was a problem hiding this comment.
With crate/crate@837db42, it is also supported on numeric and timestamp types but this is not yet released, master/nightly only (will be part of CrateDB 5.4. So yes fine like that for now.
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
| @@ -232,3 +232,30 @@ | |||
| a = sa.Column(Geopoint, crate_index=False) | |||
| with self.assertRaises(sa.exc.CompileError): | |||
| self.Base.metadata.create_all(bind=self.engine) | |||
|
|
|||
| def test_text_column_without_columnstore(self): | |||
| class DummyTable(self.Base): | |||
Check notice
Code scanning / CodeQL
Unused local variable Note
There was a problem hiding this comment.
We know this admonition by CodeQL on those occasions. They can be dismissed as false positive.
There was a problem hiding this comment.
Ah... I was already wondering if there is a way to make CodeQL ignore it. I'm happy with them being dismissed tho.
There was a problem hiding this comment.
Yes, dismissing them is the maximum we can do here. But unfortunately, the corresponding admonition items will never be collapsed. Instead, they will be displayed "expanded" here, into eternity, even if we would resolve this conversation about it.
Unfortunately, there is also no other way to mitigate warnings on such spots, or to acknowledge them upfront, for example, by placing corresponding annotations into the code.
There was a problem hiding this comment.
Hi again. CodeQL admonition items will be made collapsible, it's so sweet. Thank you, @anaarmas.
|
Dear Matthias, after adding a changelog item to your patch, I've just merged it. Thank you again. With kind regards, |
Summary of the changes / Why this is an improvement
This allows to disable column store for a text column using:
Which will yield:
Checklist