-
-
Notifications
You must be signed in to change notification settings - Fork 60
Fix crashes in shared.py and plot.py #202
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
|
@TimidRobot Sorry about missing the template again, and thanks for your patience. I appreciate you holding the bar high, I’ll update the PR to follow the template and re request review. If there’s anything else you’d like, just let me know! |
|
@TimidRobot I’ve made the changes and updated the PR description to match the template. Could you please take another look and let me know if anything else is needed? Thanks! |
The Checklist instructions include: <!-- DON'T remove this section or any of the lines. -->
<!-- Leave incomplete or inapplicable lines unchecked. -->
<!-- Replace the [ ] with [x] to check the boxes (there is no space between x and square brackets). -->The template is located here: creativecommons/.github/blob/main/.github/PULL_REQUEST_TEMPLATE.md Pull requests without the Developer Certificate of Origin section won't be accepted 🙅🏻 |
|
@TimidRobot Sorry for the repeated mistakes. I’ve carefully updated the PR to match the template. i will pay more attention to structured way of contributinng to opensource from now on. does this update match the things you were reminding me of? |
Yes, the description looks much better now. Thank you. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for identifying and fixing these issues
|
@TimidRobot Thanks so much for your help and guidance throughout this process |
Fixes
Description
This pull request fixes crashes found while testing the scripts:
scripts/shared.pycrashed with an IndexError when processing certain README files.scripts/plot.pyhad an issue with color cycling that caused index errors.scripts/1-fetch/gcs_fetch.pyretry loop could get stuck on some HTTP errors.Technical details
shared.pyto avoid IndexError when parsing README files.plot.pyto prevent index errors.gcs_fetch.pyto avoid infinite retries on non retryable HTTP errors.Tests
To verify:
Screenshots
Checklist
Update index.md).mainormaster).visible errors.
Developer Certificate of Origin
For the purposes of this DCO, "license" is equivalent to "license or public domain dedication," and "open source license" is equivalent to "open content license or public domain dedication."
Developer Certificate of Origin