fix: concurrent calls not authorized and LDAP timeout #20
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In some cases like network connectivity lost, the LDAP bind request is waiting indefinetely. To avoid that, we to a timeout on the LDAP request by closing the LDAP connection.
SergeShpak
previously requested changes
Aug 24, 2023
kpetremann
force-pushed
the
ldap_fix
branch
2 times, most recently
from
21d35dc to
668cd94
Compare
Max connection lifetime is the maximum time a LDAP connection will be re-used for authentication requests. Default is 1 minute. This is not a guarantee: - the LDAP could close the connection - the TCP connection could be closed (timeout if the max connection lifetime is too high, issues etc...)
fdomain
reviewed
Sep 21, 2023
kpetremann
force-pushed
the
ldap_fix
branch
from
276c922 to
6df0708
Compare
kpetremann
force-pushed
the
ldap_fix
branch
from
6df0708 to
2c8153a
Compare
fdomain
approved these changes
Sep 21, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix two LDAP issues: