Skip to content

fix(ldap): deadlock when failed to connect to LDAP #38

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Sep 13, 2024
Merged

fix(ldap): deadlock when failed to connect to LDAP #38

merged 1 commit into from
Sep 13, 2024

Conversation

kpetremann
Copy link
Member

Deadlock happened when failed to reconnect to the LDAP because we send a response to the channel twice:

  • line 109: once during the failure handling
  • line 137: reached because of the for loop break

note: auth is false by default.

@kpetremann kpetremann requested review from a team September 13, 2024 10:54
fdomain
fdomain approved these changes Sep 13, 2024
View reviewed changes
Copy link
Contributor

@fdomain fdomain left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

good catch

@kpetremann kpetremann merged commit 23228f9 into criteo:main Sep 13, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@fdomain fdomain fdomain approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@kpetremann @fdomain