Improve deadline exceed message #65
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Deadline exceeded is what the status of a node disruption will show once a Node Disruption is fully rejected. Most of the time, we reach the deadline because some budgets are preventing from reaching the granted state. In the previous version, we lost the context and had to look at logs. Now we keep the previous status and only append a reason. This way we know why the last attempt was rejected.
komuta
reviewed
Jun 7, 2024
Make the reference calculation a method from ndr Remove redondant error handling for RejectOverlappingDisruption
komuta
approved these changes
Jun 17, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Deadline exceeded is what the status of a node disruption will show once a Node Disruption is fully rejected. Most of the time, we reach the deadline because some budgets are preventing from reaching the granted state. In the previous version, we lost the context and had to look at logs. Now we keep the previous status and only append a reason. This way we know why the last attempt was rejected.