Skip to content

Conversation

@elecming
Copy link
Contributor

👮🏻👮🏻👮🏻 !!!! REFERENCE THE PROBLEM YOUR ARE SOLVING IN THE PR TITLE AND DESCRIBE YOUR SOLUTION HERE !!!! DO NOT FORGET !!!! 👮🏻👮🏻👮🏻

PR Checklist:

  • Have you read the CONTRIBUTING.md?
  • Does your PR follow the C4 patch requirements?
  • Have you rebased your work on top of the latest main?
  • Have you checked your code compiles? (cargo build)
  • Have you included tests for any non-trivial functionality?
  • Have you checked your code passes the unit tests? (cargo test)
  • Have you checked your code formatting is correct? (cargo fmt -- --check --color=auto)
  • Have you checked your basic code style is fine? (cargo clippy)
  • If you added any dependencies, have you checked they do not contain any known vulnerabilities? (cargo audit)
  • If your changes affect public APIs, does your PR follow the C4 evolution of public contracts?
  • If your code changes public APIs, have you incremented the crate version numbers and documented your changes in the CHANGELOG.md?
  • If you are contributing for the first time, please read the agreement in CONTRIBUTING.md now and add a comment to this pull request stating that your PR is in accordance with the Developer's Certificate of Origin.

Thank you for your code, it's appreciated! :)

Co-authored-by: Tomas Tauber <2410580+tomtau@users.noreply.github.com>
@codecov-commenter
Copy link

Codecov Report

Merging #310 (0ebb937) into main (73baeae) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main     #310   +/-   ##
=======================================
  Coverage   25.27%   25.27%           
=======================================
  Files          20       20           
  Lines        2216     2216           
=======================================
  Hits          560      560           
  Misses       1656     1656           

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

Copy link
Collaborator

@leejw51crypto leejw51crypto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@leejw51crypto leejw51crypto merged commit f3e2dfa into cronos-labs:main Dec 13, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants