-
Notifications
You must be signed in to change notification settings - Fork 145
Double check all MR examples #966
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
negz
commented
Aug 12, 2025
- Make sure they're using v2.0.0 providers
- Make sure they use m.example.org style API groups
- Make sure they're namespaced
✅ Deploy Preview for crossplane ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
jbw976
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thanks @negz! the only feedback is about the non-upjet provider not having a v2 yet. There's a few places that should be addressed 🙇♂️
0784ec0 to
b6a5411
Compare
|
@jbw976 I took another pass, and tried to standardize everything on using the family providers that support v2 style namespaced MRs. I also noticed we needed to update how ProviderConfigs now work. CC @sergenyalcin @erhancagirici @jeanduplessis - want to take a look at this for accuracy? P.S. I tested all the (full) example MRs, Providers, and ProviderConfigs against a real kind cluster running Crossplane v2.0.2 (and using v2.0.0 of provider family AWS) to make sure they were schematically valid (i.e. dry run applied successfully). |
A few of the other providers like GCP and Azure now do. The rest will fast follow. Also, it's not misleading to say the others don't support v2. That reads like they're incompatible, which they're not. They're just not namespaced yet. Signed-off-by: Nic Cope <nicc@rk0n.org>
0c9f12c to
7bdac61
Compare
* Make sure they're using v2.0.0 providers * Make sure they use m.example.org style API groups * Make sure they're namespaced Signed-off-by: Nic Cope <nicc@rk0n.org>
