Skip to content

Conversation

@jbw976
Copy link
Member

@jbw976 jbw976 commented Aug 13, 2025

This PR removes obsolete analytics from the docs site infrastructure. There is no need for these analytics anymore, so they can be safely removed.

Looks like some white space changes (remove trailing whitespace) made it in automatically from my editor too.

I have tested these changes as described in #972 (comment)

Signed-off-by: Jared Watts <jbw976@gmail.com>
@netlify
Copy link

netlify bot commented Aug 13, 2025

Deploy Preview for crossplane ready!

Name Link
🔨 Latest commit 62bdf17
🔍 Latest deploy log https://app.netlify.com/projects/crossplane/deploys/689d162980e1810008140eda
😎 Deploy Preview https://deploy-preview-972--crossplane.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
Lighthouse
Lighthouse
1 paths audited
Performance: 90 (🟢 up 9 from production)
Accessibility: 90 (🔴 down 2 from production)
Best Practices: 83 (no change from production)
SEO: 100 (no change from production)
PWA: 70 (no change from production)
View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to your Netlify project configuration.

@jbw976
Copy link
Member Author

jbw976 commented Aug 13, 2025

Hmm, this may be tricky to actually test because the analytics aren't included unless it's a production deployment:
https://github.com/crossplane/docs/blob/master/themes/geekboot/layouts/partials/scripts.html#L6-L8

any ideas from folks? 🤔

@jbw976
Copy link
Member Author

jbw976 commented Aug 14, 2025

I was able to test this well locally with hugo server and the following approach:

I think this is tested enough to review now, taking out of draft 💪

@jbw976 jbw976 marked this pull request as ready for review August 14, 2025 00:37
Copy link
Member

@negz negz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. I've noticed AI tools like Claude Code seem to add trailing whitespace here and there. I might try find a way to auto-remove it without relying on editors - sed command in Makefile or something?

@jbw976
Copy link
Member Author

jbw976 commented Aug 14, 2025

I also believe a lot of the trailing whitespace is from human edits made long ago and haven't been touched in a long time, e.g. the docs infrastructure page 😉

@jbw976 jbw976 merged commit b652a64 into crossplane:master Aug 14, 2025
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants