PLAT-5595: Modularize the scaffolds - Modules #103
Conversation
santoshpy
requested review from
alaisgomes,
andresmachado,
cruz636,
danielsousaio,
driverdan and
mabdullahabid
danielsousaio
left a comment
danielsousaio
left a comment
There was a problem hiding this comment.
Please consider the related review on crowdbotics/django-scaffold.
| @@ -1,37 +1,52 @@ | |||
| # ProjectName | |||
| # {{cookiecutter.project_slug}} | |||
There was a problem hiding this comment.
@danielsousaio would changing the ProjectName to cookiecutter.project_slug work here? I don't think so. Can you confirm?
| @@ -1,37 +1,52 @@ | |||
| # ProjectName | |||
| # {{cookiecutter.project_slug}} | |||
There was a problem hiding this comment.
The logic for using the mobile folder and handle all subsequent actions after in scaffold/install.js looks okay to me. However, I am not able to review the correctness of the syntax of this JavaScript file.
@danielsousaio can you confirm if this looks good?
@santoshpy There are merge conflicts (which is expected) so maybe you should merge master into this branch and then handle conflicts accordingly.
|
@santoshpy Please fix the merge conflicts |
|
Closing stale PR |
Ticket
PLAT-5595
Related tickets: PLAT-5595
Related PRs:
Type of PR
Changes introduced
Manage the folder structure for backend and mobile scaffold.
Update README.md file for consistency
Test and review
AS this PR is related to PLATFORM-DASHBOARD to test it, Need to merge all related PR.