Skip to content

Conversation

@FaizaJibril
Copy link
Contributor

@FaizaJibril FaizaJibril commented Oct 3, 2025

  • Added Task Comments support to the Python SDK
  • Implemented list/get/add/delete/edit endpoints
  • Exposed client accessor client.task_comments
  • Wired exports in api_resources/init.py

@FaizaJibril FaizaJibril closed this Oct 4, 2025
@FaizaJibril FaizaJibril reopened this Oct 4, 2025
@FaizaJibril
Copy link
Contributor Author

  1. Hi @andrii-bodnar , these checks are failing, and I am unable to resolve them. Any pointers?

@andrii-bodnar andrii-bodnar linked an issue Oct 7, 2025 that may be closed by this pull request
@andrii-bodnar
Copy link
Member

Hi @FaizaJibril, thank you for the contribution!
As I can see, it somehow related to newlines and blank lines:

./crowdin_api/api_resources/task_comments/__init__.py:5:2: W292 no newline at end of file
] ^
./crowdin_api/api_resources/task_comments/enums.py:6:1: W391 blank line at end of file

^
./crowdin_api/api_resources/task_comments/resource.py:126:1: W391 blank line at end of file

^
./crowdin_api/api_resources/task_comments/tests/test_task_comments_resources.py:113:1: W391 blank line at end of file

^
./crowdin_api/api_resources/task_comments/types.py:12:1: W391 blank line at end of file

^
1     W292 no newline at end of file
4     W391 blank line at end of file

@codecov-commenter
Copy link

codecov-commenter commented Oct 7, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 99.37%. Comparing base (36afa7b) to head (bae72f9).
⚠️ Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #216      +/-   ##
==========================================
+ Coverage   99.36%   99.37%   +0.01%     
==========================================
  Files         178      178              
  Lines        8066     8128      +62     
  Branches      184      185       +1     
==========================================
+ Hits         8014     8076      +62     
  Misses         37       37              
  Partials       15       15              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@FaizaJibril
Copy link
Contributor Author

okay @andrii-bodnar checks passed now! yay

@andrii-bodnar
Copy link
Member

@FaizaJibril thank you! I would suggest moving the task comments methods under the existing tasks resource instead of creating a new one. This would better align with the API docs structure, in which all these methods are located in the Tasks section.

@FaizaJibril
Copy link
Contributor Author

Hi @andrii-bodnar please check now

@andrii-bodnar
Copy link
Member

andrii-bodnar commented Oct 9, 2025

Hi @FaizaJibril, there is still task_comments resource in this PR (API resource and tests)

@FaizaJibril
Copy link
Contributor Author

FaizaJibril commented Oct 9, 2025

Hi @andrii-bodnar I have removed the task_comments resource. Please can you check now ?

Copy link
Member

@andrii-bodnar andrii-bodnar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In addition, please add tests for task comments in the crowdin_api/api_resources/tasks/tests/test_tasks_resources.py

@andrii-bodnar andrii-bodnar changed the title feat(tasks): add TaskCommentsResource and client accessor feat(tasks): add task comments support Oct 10, 2025
@andrii-bodnar
Copy link
Member

@FaizaJibril thank you for the contribution!

@andrii-bodnar andrii-bodnar merged commit 22a943e into crowdin:main Oct 13, 2025
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add support for new Task Comments API

3 participants