-
Notifications
You must be signed in to change notification settings - Fork 39
feat(tasks): add task comments support #216
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
|
Hi @FaizaJibril, thank you for the contribution! |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #216 +/- ##
==========================================
+ Coverage 99.36% 99.37% +0.01%
==========================================
Files 178 178
Lines 8066 8128 +62
Branches 184 185 +1
==========================================
+ Hits 8014 8076 +62
Misses 37 37
Partials 15 15 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
okay @andrii-bodnar checks passed now! yay |
|
@FaizaJibril thank you! I would suggest moving the task comments methods under the existing |
|
Hi @andrii-bodnar please check now |
|
Hi @FaizaJibril, there is still task_comments resource in this PR (API resource and tests) |
|
Hi @andrii-bodnar I have removed the task_comments resource. Please can you check now ? |
andrii-bodnar
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In addition, please add tests for task comments in the crowdin_api/api_resources/tasks/tests/test_tasks_resources.py
|
@FaizaJibril thank you for the contribution! |
Uh oh!
There was an error while loading. Please reload this page.