Breaks Python garbage collection #14
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The Python garbage collector (GC) nowadays can free cyclic structure, but only if that cycle does NOT contain objects implementing the `__del__` method, as the GC then cannot decide which object to free first: That method is only called *after* the GC has decided to free the object and then it is pointless to clean the exception data. Remove the `__del__` method. <https://docs.python.org/2/library/gc.html#gc.garbage>
The Python garbage collector (GC) nowadays can free cyclic structure, but keeping a Traceback object is still considered a bad idea: It contains a reference to all stack frames, which reference all local variables, and thus the traceback itself. Format the traceback once and replace the reference with None. The standard traceback library handles this fine. <https://docs.python.org/2/library/sys.html#sys.exc_info>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
python-notifier.thread.Simple objects are not garbage collected as they implement the
__del__method. See individual commit message and Bug #47114 for more details.