Skip to content

Breaks Python garbage collection #14

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jul 4, 2018
Merged

Breaks Python garbage collection #14

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
13e2dec
Bug #47114: Fix memory leak - __del__
pmhahn Jul 4, 2018
7715a44
Bug #47114: Fix memory leak - traceback
pmhahn Jul 4, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 6 additions & 6 deletions notifier/threads.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -66,10 +66,6 @@ def __init__( self, name, function, callback ):
notifier.dispatcher_add( _simple_threads_dispatcher )
_threads.append( self )

def __del__( self ):
if self._exc_info is not None:
del self._exc_info

def run( self ):
"""Starts the thread"""
self._thread.start()
Expand All @@ -83,8 +79,12 @@ def _run( self ):
trace = None
exc_info = None
except BaseException as exc:
exc_info = sys.exc_info()
trace = traceback.format_tb( sys.exc_info()[ 2 ] )
try:
etype, value, tb = sys.exc_info()
trace = traceback.format_tb(tb)
exc_info = (etype, value, None)
finally:
etype = value = tb = None
result = exc
self.lock()
try:
Expand Down