Skip to content

feat: add more msp_config data for ORP settings #68

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Jan 15, 2025
Merged

feat: add more msp_config data for ORP settings #68

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
18cbdc3
feat: add more msp_config data for ORP settings
cryptk Jan 15, 2025
b4039ad
fix: update poetry action
cryptk Jan 15, 2025
9414ffa
fix: fix poetry install for pre-commit
cryptk Jan 15, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
26 changes: 22 additions & 4 deletions .github/workflows/ci.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,12 +24,25 @@ jobs:
- uses: wagoid/commitlint-github-action@v5.3.0
lint:
runs-on: ubuntu-latest
strategy:
matrix:
python-version:
- "3.13"
poetry-version:
- "2.0.0"
steps:
- uses: actions/checkout@v3
- uses: actions/setup-python@v4
- name: Set up Python
uses: actions/setup-python@v4
with:
python-version: "3.13"
- uses: abatilo/actions-poetry@v2.3.0
python-version: ${{ matrix.python-version }}
- name: Set up Poetry
uses: abatilo/actions-poetry@v4.0.0
with:
poetry-version: ${{ matrix.poetry-version }}
- name: Install Dependencies
run: poetry install
shell: bash
- uses: pre-commit/action@v3.0.0

test:
Expand All @@ -38,6 +51,8 @@ jobs:
matrix:
python-version:
- "3.13"
poetry-version:
- "2.0.0"
os:
- ubuntu-latest
- windows-latest
Expand All @@ -49,7 +64,10 @@ jobs:
uses: actions/setup-python@v4
with:
python-version: ${{ matrix.python-version }}
- uses: abatilo/actions-poetry@v2.3.0
- name: Set up Poetry
uses: abatilo/actions-poetry@v4.0.0
with:
poetry-version: ${{ matrix.poetry-version }}
- name: Install Dependencies
run: poetry install
shell: bash
Expand Down
6 changes: 6 additions & 0 deletions pyomnilogic_local/models/mspconfig.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -174,6 +174,12 @@ class MSPCSAD(OmniBase):
calibration_value: float = Field(alias="CalibrationValue")
ph_low_alarm_value: float = Field(alias="PHLowAlarmLevel")
ph_high_alarm_value: float = Field(alias="PHHighAlarmLevel")
orp_target_level: int = Field(alias="ORP-Target-Level")
orp_runtime_level: int = Field(alias="ORP-Runtime-Level")
orp_low_alarm_level: int = Field(alias="ORP-Low-Alarm-Level")
orp_high_alarm_level: int = Field(alias="ORP-High-Alarm-Level")
orp_forced_on_time: int = Field(alias="ORP-Forced-On-Time")
orp_forced_enabled: bool = Field(alias="ORP-Forced-Enabled")


class MSPColorLogicLight(OmniBase):
Expand Down
Loading