Ditch non-working QA plugin #165
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
crypto-matto
requested review from
calvinaco,
landanhu and
tomtau
as code owners
Contributor
|
/staging |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue
Existing setup for QA with the official suggested plugin is not working. Inject scripts directly instead.
Screenshot
Potential Issue
Vuepress is a single page web application. Browse between different pages within Docs may not fire a pageview action to GA.
Reference
https://www.sofineday.com/vuepress-google-analytics.html#%E9%85%8D%E7%BD%AE-%E8%B0%B7%E6%AD%8C-%E7%BB%9F%E8%AE%A1%E4%BB%A3%E7%A0%81