Skip to content

Conversation

@thomas-nguy
Copy link

Closes: #XXX

Description


For contributor use:

  • Targeted PR against correct branch (see CONTRIBUTING.md)
  • Linked to Github issue with discussion and accepted design OR link to spec that describes this work.
  • Code follows the module structure standards.
  • Wrote unit and integration tests
  • Updated relevant documentation (docs/) or specification (x/<module>/spec/)
  • Added relevant godoc comments.
  • Added a relevant changelog entry to the Unreleased section in CHANGELOG.md
  • Re-reviewed Files changed in the Github PR explorer

For admin use:

  • Added appropriate labels to PR (ex. WIP, R4R, docs, etc)
  • Reviewers assigned
  • Squashed all commits, uses message "Merge pull request #XYZ: [title]" (coding standards)

@thomas-nguy thomas-nguy requested a review from a team as a code owner September 5, 2025 04:03
@thomas-nguy thomas-nguy requested review from XinyuCRO and randy-cro and removed request for a team September 5, 2025 04:03
@thomas-nguy thomas-nguy marked this pull request as draft September 5, 2025 04:03
@github-actions github-actions bot added the evm label Sep 5, 2025
@github-actions

This comment has been minimized.

@thomas-nguy thomas-nguy force-pushed the thomas/eip-2935-support branch from 932e118 to 382a950 Compare September 5, 2025 05:12
@codecov
Copy link

codecov bot commented Sep 8, 2025

Codecov Report

❌ Patch coverage is 85.93750% with 9 lines in your changes missing coverage. Please review.
✅ Project coverage is 46.30%. Comparing base (06f5a7b) to head (ab83b17).
⚠️ Report is 2 commits behind head on develop.

Files with missing lines Patch % Lines
x/evm/keeper/keeper.go 88.09% 3 Missing and 2 partials ⚠️
x/evm/keeper/state_transition.go 80.95% 3 Missing and 1 partial ⚠️
Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff             @@
##           develop     #722      +/-   ##
===========================================
+ Coverage    46.22%   46.30%   +0.08%     
===========================================
  Files          189      189              
  Lines        19056    19092      +36     
===========================================
+ Hits          8808     8841      +33     
- Misses        9453     9455       +2     
- Partials       795      796       +1     
Files with missing lines Coverage Δ
x/evm/types/params.go 38.35% <100.00%> (+0.85%) ⬆️
x/evm/keeper/state_transition.go 71.51% <80.95%> (+0.17%) ⬆️
x/evm/keeper/keeper.go 72.85% <88.09%> (+3.16%) ⬆️
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@thomas-nguy
Copy link
Author

This PR is blocked by missing pre-install functionality

@thomas-nguy thomas-nguy force-pushed the thomas/eip-2935-support branch from 88ff389 to 2ed846a Compare October 3, 2025 01:17
@thomas-nguy thomas-nguy marked this pull request as ready for review October 3, 2025 01:26
@thomas-nguy thomas-nguy force-pushed the thomas/eip-2935-support branch from 353394c to 12f1d7f Compare October 3, 2025 14:35
@thomas-nguy
Copy link
Author

integration tests
crypto-org-chain/cronos#1882

@thomas-nguy thomas-nguy force-pushed the thomas/eip-2935-support branch from 47991a2 to d6c0c69 Compare October 4, 2025 06:55
Copy link

@JayT106 JayT106 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@thomas-nguy thomas-nguy enabled auto-merge (squash) October 7, 2025 01:10
@thomas-nguy thomas-nguy merged commit 164da0c into crypto-org-chain:develop Oct 7, 2025
45 checks passed
@thomas-nguy thomas-nguy deleted the thomas/eip-2935-support branch October 7, 2025 01:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants