Skip to content

Conversation

@thomas-nguy
Copy link

Closes: #XXX

Description

Add command to install contracts in the state


For contributor use:

  • Targeted PR against correct branch (see CONTRIBUTING.md)
  • Linked to Github issue with discussion and accepted design OR link to spec that describes this work.
  • Code follows the module structure standards.
  • Wrote unit and integration tests
  • Updated relevant documentation (docs/) or specification (x/<module>/spec/)
  • Added relevant godoc comments.
  • Added a relevant changelog entry to the Unreleased section in CHANGELOG.md
  • Re-reviewed Files changed in the Github PR explorer

For admin use:

  • Added appropriate labels to PR (ex. WIP, R4R, docs, etc)
  • Reviewers assigned
  • Squashed all commits, uses message "Merge pull request #XYZ: [title]" (coding standards)

@thomas-nguy thomas-nguy requested a review from a team as a code owner September 9, 2025 01:26
@thomas-nguy thomas-nguy requested review from XinyuCRO and randy-cro and removed request for a team September 9, 2025 01:26
@github-actions

This comment has been minimized.

@github-actions github-actions bot added the evm label Sep 9, 2025
@thomas-nguy thomas-nguy marked this pull request as draft September 9, 2025 02:25
@github-actions github-actions bot added the ci label Sep 9, 2025
@codecov
Copy link

codecov bot commented Sep 10, 2025

Codecov Report

❌ Patch coverage is 48.41270% with 65 lines in your changes missing coverage. Please review.
✅ Project coverage is 46.22%. Comparing base (f674c51) to head (88ece54).
⚠️ Report is 1 commits behind head on develop.

Files with missing lines Patch % Lines
x/evm/keeper/keeper.go 30.61% 28 Missing and 6 partials ⚠️
x/evm/types/msg.go 0.00% 10 Missing ⚠️
x/evm/keeper/msg_server.go 0.00% 9 Missing ⚠️
x/evm/types/genesis.go 52.63% 6 Missing and 3 partials ⚠️
x/evm/genesis.go 0.00% 1 Missing and 1 partial ⚠️
x/evm/types/codec.go 50.00% 1 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff            @@
##           develop     #728    +/-   ##
=========================================
  Coverage    46.21%   46.22%            
=========================================
  Files          187      189     +2     
  Lines        18938    19056   +118     
=========================================
+ Hits          8752     8808    +56     
- Misses        9399     9453    +54     
- Partials       787      795     +8     
Files with missing lines Coverage Δ
evmd/app.go 79.49% <100.00%> (+0.11%) ⬆️
evmd/genesis.go 100.00% <100.00%> (ø)
x/evm/keeper/grpc_query.go 73.69% <ø> (-0.05%) ⬇️
x/evm/simulation/genesis.go 67.74% <100.00%> (ø)
x/evm/types/errors.go 100.00% <ø> (ø)
x/evm/types/preinstall.go 100.00% <100.00%> (ø)
x/evm/types/utils.go 33.11% <100.00%> (+0.89%) ⬆️
x/evm/types/codec.go 38.00% <50.00%> (+0.50%) ⬆️
x/evm/genesis.go 51.61% <0.00%> (-1.73%) ⬇️
x/evm/keeper/msg_server.go 79.00% <0.00%> (-7.82%) ⬇️
... and 3 more

... and 1 file with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@thomas-nguy thomas-nguy force-pushed the thomas/support-preinstall branch 2 times, most recently from 5b1c6f8 to 5a89606 Compare September 15, 2025 12:18
@thomas-nguy thomas-nguy force-pushed the thomas/support-preinstall branch 6 times, most recently from dd2e3ea to 0168915 Compare September 26, 2025 03:40
@thomas-nguy thomas-nguy marked this pull request as ready for review September 26, 2025 03:55
@thomas-nguy thomas-nguy force-pushed the thomas/support-preinstall branch from f51be29 to 1ace71a Compare September 28, 2025 14:26
@thomas-nguy thomas-nguy force-pushed the thomas/support-preinstall branch from 1ace71a to d9ffd83 Compare September 28, 2025 14:35
@thomas-nguy thomas-nguy changed the title feat: support preinstall feat: support preinstalls Sep 28, 2025
@thomas-nguy
Copy link
Author

Integration tests

crypto-org-chain/cronos#1875

@songgaoye
Copy link

songgaoye commented Sep 29, 2025

I see

_ sdk.Msg = &MsgEthereumTx{}
_ sdk.Tx = &MsgEthereumTx{}
_ ante.GasTx = &MsgEthereumTx{}
_ sdk.Msg = &MsgUpdateParams{}

Do we also need to this for MsgRegisterPreinstalls?

@thomas-nguy
Copy link
Author

Do we also need to this for MsgRegisterPreinstalls?

Added the static type check for MsgRegisterPreinstalls

@thomas-nguy thomas-nguy force-pushed the thomas/support-preinstall branch from 246e9c3 to 202679e Compare September 30, 2025 07:58
Copy link

@JayT106 JayT106 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@thomas-nguy thomas-nguy merged commit 63f3de0 into crypto-org-chain:develop Oct 2, 2025
45 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants