Feature: Do not add nullbytes when persisting Long Filename #122
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
infeo
changed the title
overheadhunter
requested changes
Dec 15, 2021
Member
overheadhunter
left a comment
overheadhunter
left a comment
There was a problem hiding this comment.
I believe we can broaden this fix for further unprintable chars. And simplify the check. And rename some methods. 😉
src/main/java/org/cryptomator/cryptofs/health/shortened/ShortenedNamesCheck.java
Outdated
Show resolved
Hide resolved
src/main/java/org/cryptomator/cryptofs/health/shortened/ShortenedNamesCheck.java
Outdated
Show resolved
Hide resolved
src/main/java/org/cryptomator/cryptofs/health/shortened/ShortenedNamesCheck.java
Outdated
Show resolved
Hide resolved
src/main/java/org/cryptomator/cryptofs/health/shortened/ShortenedNamesCheck.java
Outdated
Show resolved
Hide resolved
src/main/java/org/cryptomator/cryptofs/health/shortened/ShortenedNamesCheck.java
Outdated
Show resolved
Hide resolved
src/main/java/org/cryptomator/cryptofs/health/shortened/TrailingNullBytesInNameFile.java
Outdated
Show resolved
Hide resolved
… so split string at that position, check before for base64url and after for any byte * adjust check, results and unit tests * add doc
overheadhunter
approved these changes
Dec 16, 2021
Member
overheadhunter
left a comment
overheadhunter
left a comment
There was a problem hiding this comment.
Just a suggestion, but I'm fine to merge it as is.
src/main/java/org/cryptomator/cryptofs/health/shortened/ShortenedNamesCheck.java
Show resolved
Hide resolved
|
SonarCloud Quality Gate failed. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This closes #121.
It adds two additional results to the shortend health check:
NotDecodableLongNameif the long filename ist not base64url encodedTrailingNullBytesif the stored string in name.c9s is affected by issue Long filesnames are persisted with NULL Bytes at the end #121