Feature/reveal files service #16
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tobihagemann
requested changes
Jan 10, 2023
src/main/java/org/cryptomator/integrations/common/IntegrationService.java
Outdated
Show resolved
Hide resolved
src/main/java/org/cryptomator/integrations/revealpaths/RevealPathsService.java
Outdated
Show resolved
Hide resolved
src/main/java/org/cryptomator/integrations/revealpaths/RevealPathsService.java
Outdated
Show resolved
Hide resolved
* for files, select file in file manager * for directory, just open dir in file manager
Member
Author
|
After a discussion the spec is now changed: The API requires to differentiate between files and folders:
This ensures a clear API without any exceptions or "unspecified" behaviour. |
tobihagemann
requested changes
Jan 11, 2023
src/main/java/org/cryptomator/integrations/revealpath/RevealPathService.java
Outdated
Show resolved
Hide resolved
src/main/java/org/cryptomator/integrations/revealpath/RevealPathService.java
Outdated
Show resolved
Hide resolved
Co-authored-by: Tobias Hagemann <tobias.hagemann@skymatic.de>
tobihagemann
approved these changes
Jan 11, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds the RevealPathsService to the library.
The service is intended to open for a given path the system default file manager with the path in the file manager selection.
Until commit 53f7b57 (exlcuding), there was also a function to reveal several paths, but this part needs more work.