Fix up some docker build/running issues #110
Open
+7
−13
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Use exec in docker-entrypoint.sh to replace the shell process with the Python process, making it PID 1. This ensures SIGTERM and SIGINT signals are properly received and handled during shutdown, preventing the container from hanging indefinitely when stopped. Without exec, the shell script remains as PID 1 and doesn't forward signals to the child Python process, causing it to wait forever for stdin to close in stdio mode. Reproducer: ``` $DOCKER run -p 8000:8000 -e DATABASE_URI -access-mode=restricted --transport=sse ``` Without these changes, `^C` does not work and the process is hung forever. After these changes `^C` properly exits. Assisted-by: Cursor AI
I'm not able to build the Dockerfile as the `app` user doesn't exist in the base image. This creates it. It also makes sure the app runs as non-root.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #103
Use exec in docker-entrypoint.sh to replace the shell process with
the Python process, making it PID 1. This ensures SIGTERM and SIGINT
signals are properly received and handled during shutdown, preventing
the container from hanging indefinitely when stopped.
Without exec, the shell script remains as PID 1 and doesn't forward
signals to the child Python process, causing it to wait forever for
stdin to close in stdio mode.
Reproducer:
Without these changes,
^Cdoes not work and the process is hungforever. After these changes
^Cproperly exits.Also fixes to build the postgres container, the
appuser doesn't seem to exist in the base image.