Improve exception handling #21
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
October 1, 2018 22:40
Changed all Exception objects raised to more specific classes implemented in pyevmasm. Additionally, disassemble_all now catches a ParseError exception that could be thrown by Instruction.parse_operand, which would cause the generator to raise an exception instead of returning None.
Rather than just a `return` statement, `StopIteration` makes it clearer that the generator is done. They're functionally equivalent, but it's better for clarity in my opinion.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changed all
Exceptionobjects raised to more specific classes implemented in pyevmasm.Additionally,
disassemble_allnow catches aParseErrorexception that could be thrown byInstruction.parse_operand, which would cause the generator to raise an exception instead of returningNone.