Bugfixes for building executable #322
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit has several bug fixes. - Add required python packages that were missing from setup.py - Add hiddenimports for pyinstaller so that pyinstaller properly loads gevent - Modify noxfile so that it loads the required packages when creating a session. Also, python 3.7 support was added in pyinstaller 3.4, so pyinstaller version needs to be updated.
Contributor
Author
|
This PR resolves issue #321 |
Owner
|
Thanks, I will try to take a look this weekend |
Owner
|
Looks good, thank you! |
cs01
pushed a commit
that referenced
this pull request
Jul 14, 2020
* Bugfixes for building executable This commit has several bug fixes. - Add required python packages that were missing from setup.py - Add hiddenimports for pyinstaller so that pyinstaller properly loads gevent - Modify noxfile so that it loads the required packages when creating a session. Also, python 3.7 support was added in pyinstaller 3.4, so pyinstaller version needs to be updated. * General cleanup
cs01
pushed a commit
that referenced
this pull request
Jul 14, 2020
* Bugfixes for building executable This commit has several bug fixes. - Add required python packages that were missing from setup.py - Add hiddenimports for pyinstaller so that pyinstaller properly loads gevent - Modify noxfile so that it loads the required packages when creating a session. Also, python 3.7 support was added in pyinstaller 3.4, so pyinstaller version needs to be updated. * General cleanup
cs01
pushed a commit
that referenced
this pull request
Jul 18, 2020
* Bugfixes for building executable This commit has several bug fixes. - Add required python packages that were missing from setup.py - Add hiddenimports for pyinstaller so that pyinstaller properly loads gevent - Modify noxfile so that it loads the required packages when creating a session. Also, python 3.7 support was added in pyinstaller 3.4, so pyinstaller version needs to be updated. * General cleanup
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit has several bug fixes. Building on MacOS is broken by default without these changes:
Add required python packages that were missing from setup.py; a clean computer install would throw an exception due to missing packages.
Add hiddenimports for pyinstaller, so that pyinstaller properly loads gevent
Modify noxfile so that it loads the required packages when creating a session. Also, python 3.7 support was added in pyinstaller 3.4, so pyinstaller version needs to be updated.