-
Notifications
You must be signed in to change notification settings - Fork 522
build binaries with github actions #334
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
See also: https://rtyley.github.io/bfg-repo-cleaner git clone --mirror https://github.com/cs01/gdbgui.git
bfg --delete-files downloads gdbgui.git |
.github/workflows/release.yml
Outdated
| # if: startsWith(github.ref, 'refs/tags/') | ||
| # env: | ||
| # GHR_PATH: FIXME | ||
| # GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You could also use https://github.com/actions/upload-artifact to attach artifacts to the current github actions run.
|
There is some documentation that points to those binaries which will need to be updated. |
|
Depends on: #335 |
|
Thanks, I will try to take a look this weekend |
Cool, once we have the binaries compiled, then we'll be good to go! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I noticed there were some syntax errors and lint errors preventing basically anything from working, including building the executables. I fixed the, so this PR should be rebased on the latest master commit.
I verified the ubuntu build still works, but the Windows build failed. I didn't re-test on a mac since I'm on unix right now. The windows build might do better outside of docker in github actions, with a runs-on of windows-2019. I'll be happy to delete that windows Dockerfile since it contains a lot of black magic, so hopefully it works. If not, it will have to be fixed up to account for whatever changed in the the apt repos, etc.
How do we confirm the GitHub actions are working? I want to be sure they work and inspect the published files before deleting them from the gdbgui github repo. I went to the actions tab but didn't see anything.
.github/workflows/release.yml
Outdated
| runs-on: macOS-latest | ||
| strategy: | ||
| matrix: | ||
| python-version: [3.5, 3.6, 3.7, 3.8] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
why is this being built with so many versions?
|
I made a new branch based off this and got everything working except for associating the artifacts with the release itself: https://github.com/cs01/gdbgui/tree/cs01/test-actions. I recommend resetting this PR to that branch. Re associated artifacts with github releases: I can look up how to do it, but if you have any tips or can reset this PR to the |
|
I will probably end up migrating all the Travis tests to GitHub actions. The actions will build the executable as well, and at the end the executable will be published. |
|
Since this PR allowed edits from maintainers I went ahead and pushed to it. Thanks for kicking off this PR and motivating me to look into GitHub actions. I'm going to land now with the following:
Some other changes made along with this:
Future work:
|
Bug: #331 * Create release.yml * Update contributing.md * make build verification more strict * change name and set nox session to non-interactive Co-authored-by: Chad Smith <cs01@users.noreply.github.com>
Bug: #331 * Create release.yml * Update contributing.md * make build verification more strict * change name and set nox session to non-interactive Co-authored-by: Chad Smith <cs01@users.noreply.github.com>
Bug: #331 * Create release.yml * Update contributing.md * make build verification more strict * change name and set nox session to non-interactive Co-authored-by: Chad Smith <cs01@users.noreply.github.com>
Closes: #331