Skip to content

lint fixes #338

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jul 13, 2020
Merged

lint fixes #338

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
7bb47d5
lint fixes
cs01 Jul 13, 2020
b3b3fcb
allow unauthenticated code to be downloaded in container
cs01 Jul 13, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions docker/windows/Dockerfile
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,7 @@ RUN set -x \
&& apt-key add Release.key \
&& add-apt-repository 'https://dl.winehq.org/wine-builds/ubuntu/' \
&& apt-get update -qy \
&& apt-get install --no-install-recommends -qfy $WINE_VERSION winbind cabextract \
&& apt-get install --allow-unauthenticated --no-install-recommends -qfy $WINE_VERSION winbind cabextract \
&& apt-get clean \
&& wget -nv https://raw.githubusercontent.com/Winetricks/winetricks/master/src/winetricks \
&& chmod +x winetricks \
Expand All @@ -36,9 +36,9 @@ ENV PYPI_INDEX_URL=https://pypi.python.org/simple
RUN set -x \
&& winetricks win7 \
&& for msifile in `echo core dev exe lib path pip tcltk tools`; do \
wget -nv "https://www.python.org/ftp/python/$PYTHON_VERSION/amd64/${msifile}.msi"; \
wine msiexec /i "${msifile}.msi" /qb TARGETDIR=C:/Python36; \
rm ${msifile}.msi; \
wget -nv "https://www.python.org/ftp/python/$PYTHON_VERSION/amd64/${msifile}.msi"; \
wine msiexec /i "${msifile}.msi" /qb TARGETDIR=C:/Python36; \
rm ${msifile}.msi; \
done \
&& cd /wine/drive_c/Python36 \
&& echo 'wine '\''C:\Python36\python.exe'\'' "$@"' > /usr/bin/python \
Expand Down
5 changes: 1 addition & 4 deletions gdbgui/src/js/Registers.jsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -50,10 +50,7 @@ class Registers extends React.Component {
}
static cache_register_names(names) {
// filter out non-empty names
store.set(
"register_names",
names.filter(name => name)
);
store.set("register_names", names.filter(name => name));
}
static clear_register_name_cache() {
store.set("register_names", []);
Expand Down
9 changes: 4 additions & 5 deletions gdbgui/src/js/process_gdb_response.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -160,10 +160,7 @@ const process_gdb_response = function(response_array) {
if ("register-names" in r.payload) {
let names = r.payload["register-names"];
// filter out empty names
store.set(
"register_names",
names.filter(name => name !== "")
);
store.set("register_names", names.filter(name => name !== ""));
}
if ("register-values" in r.payload) {
store.set("previous_register_values", store.get("current_register_values"));
Expand Down Expand Up @@ -300,7 +297,9 @@ const process_gdb_response = function(response_array) {

if (r.payload["signal-name"] !== "SIGINT") {
Actions.add_console_entries(
`gdbgui noticed a signal was received (${r.payload["signal-meaning"]}, ${r.payload["signal-name"]}).`,
`gdbgui noticed a signal was received (${r.payload["signal-meaning"]}, ${
r.payload["signal-name"]
}).`,
constants.console_entry_type.GDBGUI_OUTPUT
);
Actions.add_console_entries(
Expand Down
4 changes: 2 additions & 2 deletions setup.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,8 +12,8 @@
"Flask-Compress>=1.4.0, <2.0", # to compress flask responses
"Flask-SocketIO>=2.9, <3.0", # websocket server
"gevent>=1.2.2, <2.0", # websocket handling
"gevent-websocket>=0.10.1, <0.11", # also websocket
"eventlet>=0.25.0, <0.26". # also websocket
"gevent-websocket>=0.10.1, <0.11", # also websocket
"eventlet>=0.25.0, <0.26", # also websocket
"pygdbmi>=0.9.0.0, <1.0", # parse gdb output
"Pygments>=2.2.0, <3.0", # syntax highlighting
]
Expand Down