- 
                Notifications
    
You must be signed in to change notification settings  - Fork 33
 
          Display Metadata on /tradeoffers-pages
          #283
        
          New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
          
     Merged
      
      
    
                
     Merged
            
            
          Conversation
  
    
      This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
      Learn more about bidirectional Unicode characters
    
  
  
    
    
              
                    Step7750
  
              
              requested changes
              
                  
                    Dec 18, 2024 
                  
              
              
            
            
    
  Step7750 
      added a commit
      that referenced
      this pull request
    
      Jan 7, 2025 
    
    
      
  
    
      
    
  
Previously it included the sender in the ID, however it seems like devices such as Chrome have random properties in this for each run. Now it only caches based on the request data, tested locally using PR #283
              
                    Step7750
  
              
              requested changes
              
                  
                    Jan 8, 2025 
                  
              
              
            
            
              
                    Step7750
  
              
              approved these changes
              
                  
                    Jan 10, 2025 
                  
              
              
            
            
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
  
    Sign up for free
    to join this conversation on GitHub.
    Already have an account?
    Sign in to comment
  
      
  Add this suggestion to a batch that can be applied as a single commit.
  This suggestion is invalid because no changes were made to the code.
  Suggestions cannot be applied while the pull request is closed.
  Suggestions cannot be applied while viewing a subset of changes.
  Only one suggestion per line can be applied in a batch.
  Add this suggestion to a batch that can be applied as a single commit.
  Applying suggestions on deleted lines is not supported.
  You must change the existing code in this line in order to create a valid suggestion.
  Outdated suggestions cannot be applied.
  This suggestion has been applied or marked resolved.
  Suggestions cannot be applied from pending reviews.
  Suggestions cannot be applied on multi-line comments.
  Suggestions cannot be applied while the pull request is queued to merge.
  Suggestion cannot be applied right now. Please check back later.
  
    
  
    
Motivation
Closes #143.
Description
This PR adds the well-known enhancements from tradeoffer-popouts to the
/tradeoffers-overview:FetchSteamTrades-handler to fetch the data from the Steam API through the access tokentrade_offers.tspage script:localStorageas cache to avoid refetching from the API if there are no new trades since the last fetchTradeOfferHolderMetadataLit-component, which reads the required properties from the DOMScreenshots
Received tradeoffer example:


Sent tradeoffer example: