Improve code quality, fixes #7 #8
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
There was a problem hiding this comment.
We can add here tests as well (in watch mode, using https://github.com/kimmobrunfeldt/concurrently)
|
Great work! I used to use shell scripting to put the custom |
mightyaleksey
added a commit
that referenced
this pull request
Aug 7, 2015
Improve code quality, fixes #7
|
I'll help you with the code |
|
I fixed all errors and I like the result! Thanks :) |
|
Awesome! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I did not touch the code itself, just added ESlint and pre-commit hook.
At the moment to make a commit you need to add
-nto bypass pre-commit hook, since linting fails horribly:git commit -n -m "whatever"I want to make a separate PR to fix the code itself.