Add !important support for four-value rules, with tests#27
Closed
mattflaschen wants to merge 1 commit intowikimedia:masterfrom
Closed
Add !important support for four-value rules, with tests#27mattflaschen wants to merge 1 commit intowikimedia:masterfrom
mattflaschen wants to merge 1 commit intowikimedia:masterfrom
Conversation
Member
Use the 🌟 Thanks! |
mattflaschen
force-pushed
the
fixImportant
branch
from
fce8b92 to
7868953
Compare
The regex change was given by Bartosz Dziewoński at https://bugzilla.wikimedia.org/show_bug.cgi?id=61440#c1 . Fixes wikimedia#23
mattflaschen
force-pushed
the
fixImportant
branch
from
7868953 to
69007a5
Compare
|
Ping. It would be nice to get this merged and moving along |
Member
|
Merged in c7ca88d. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The regex change was given by Bartosz Dziewoński at https://bugzilla.wikimedia.org/show_bug.cgi?id=61440#c1.
Fixes #23