Changing mechanism #77
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
✔️ Deploy Preview for cssdb ready! 🔨 Explore the source changes: d460115 🔍 Inspect the deploy log: https://app.netlify.com/sites/cssdb/deploys/61ea69a9d2e3e90007751219 😎 Browse the preview: https://deploy-preview-77--cssdb.netlify.app |
romainmenke
reviewed
Jan 20, 2022
romainmenke
approved these changes
Jan 21, 2022
Member
romainmenke
left a comment
romainmenke
left a comment
There was a problem hiding this comment.
LGTM!
Tricky stuff, great work looking into as much cases as possible!
romainmenke
reviewed
Jan 21, 2022
tasks/populate-db.mjs
Outdated
| const newCSSDB = JSON.stringify(cleanDB, null, 2); | ||
| const esmCSSDB = `export default ${newCSSDB}`; | ||
| const newCSSDB = `${JSON.stringify(cleanDB, null, 2)}\n`; | ||
| const esmCSSDB = `export default ${newCSSDB}\n`; |
Member
There was a problem hiding this comment.
Suggested change
| const esmCSSDB = `export default ${newCSSDB}\n`; | |
| const esmCSSDB = `export default ${newCSSDB}`; |
Tiny detail :)
Final newline is already added above, so not needed here.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Not intended to be merged, want to fully check this makes sense, perhaps I was too naive automating this and we need some way to flag some things