Make batteryLow and batteryCritical inclusive #2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously, `batteryCritical` overwrote `batteryLow`, whereas, really, it’s supposed to be a subset. This means we now get both properties set to `true` and both classes added to the `<html>` once battery level is ≤5%. The upshot of which is that your customisations can be much more succinct; anything you apply to low battery users will automatically also carry over to critical, and you don’t need to do anything twice.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously,
batteryCriticaloverwrotebatteryLow, whereas, really, it’s supposed to be a subset. This means we now get both properties set totrueand both classes added to the<html>once battery level is ≤5%. The upshot of which is that your customisations can be much more succinct; anything you apply to low battery users will automatically also carry over to critical, and you don’t need to do anything twice.