Skip to content

Conversation

@Matthijsy
Copy link
Contributor

Summary

In one of the previous updates of the sponsorkliks extension we made it detectable for Amber. This PR uses this and adds an alert when someone does not have the extension installed. Remarks are welcome :)

Screenshot_2020-05-19_15-12-32

@wilco375
Copy link
Contributor

wilco375 commented May 19, 2020

The alignment is off, the left and right sides are not aligned with the articles above
Other than that it looks great

@Matthijsy
Copy link
Contributor Author

Screenshot_2020-05-19_16-37-30

@Matthijsy Matthijsy merged commit a0ce638 into staging May 20, 2020
@Matthijsy Matthijsy deleted the feature/sponsorkliks-alert branch May 20, 2020 06:09
RubenSmit pushed a commit that referenced this pull request May 20, 2020
RubenSmit added a commit that referenced this pull request May 20, 2020
This reverts commit a0ce638.

Co-authored-by: Ruben Smit <ruben@moneybird.com>
Matthijsy added a commit that referenced this pull request May 24, 2020
github-actions bot added a commit that referenced this pull request Mar 2, 2021
* Revert "Add sponsorkliks alert on main page (#153)" (#156)

This reverts commit a0ce638.

Co-authored-by: Ruben Smit <ruben@moneybird.com>

* Revert "Revert "Add sponsorkliks alert on main page (#153)" (#156)"

This reverts commit 0efb2fa.

* Fix several bugs

* Fix deleting of photo comments

* Fix authentication on public routes

* Add debouncing to filter bar

* Fix flashNotice not defined error

* Fix lint issues

Co-authored-by: Ruben Smit <RubenSmit@users.noreply.github.com>
Co-authored-by: Ruben Smit <ruben@moneybird.com>
Co-authored-by: matthijs <vos1996@gmail.com>
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
RubenSmit pushed a commit to RubenSmit/amber-ui that referenced this pull request Sep 10, 2023
* Update all Bundler dependencies (2020-05-24)

* Enable new rubocop cops by default

Co-authored-by: depfu[bot] <23717796+depfu[bot]@users.noreply.github.com>
Co-authored-by: matthijs <vos1996@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants