Skip to content

Conversation

@Anindya-K-Das
Copy link
Contributor

Split settings into different components and pages and made URL cleaner

Anindya-K-Das and others added 7 commits May 14, 2024 16:01
Created Testpage using Career page as a base. Replaced Header Logo with my name using a prop and added a component that shows my Picture and name
Co-authored-by: Sai Rangineeni <SAIRANGINEENI1@GMAIL.COM>
@vercel
Copy link

vercel bot commented May 22, 2024

@Anindya-K-Das is attempting to deploy a commit to the CTFGuide Corporation Team on Vercel.

A member of the Team first needs to authorize it.

@Laphatize Laphatize self-requested a review May 22, 2024 23:13
@sweep-ai-deprecated
Copy link

sweep-ai-deprecated bot commented May 22, 2024

Sweep: PR Review

Authors of pull request: @Anindya-K-Das

src/components/Header.jsx

Added a prop to the Header component to allow dynamic alteration of the logo text.

Sweep Found These Issues

  • The conditional rendering logic for propToChangeLogo does not handle the case where propToChangeLogo is an empty string, which could result in an empty paragraph element being rendered.
  • export function Header({propToChangeLogo}) {
    return (
    <header className="py-4 " style={{ fontFamily: 'Poppins, sans-serif' }}>
    <Container>
    <nav className="relative z-50 flex justify-between">
    <div className="flex items-center md:gap-x-12">
    {propToChangeLogo ? (<p className=' text-2xl text-white '>{propToChangeLogo}</p>):
    (<Link href="../" aria-label="Home">
    <Logo className="h-10 w-auto" />
    </Link>)}

    View Diff


The following files were not reviewed because our filter identified them as typically non-human-readable or less important files (e.g., dist files, package.json, images). If this is an error, please let us know.

  • package.json
  • yarn.lock

@Laphatize
Copy link
Member

LGTM!

@Laphatize Laphatize merged commit 2fcae20 into ctfguide-tech:dev May 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants