Skip to content

add More... link for known users#3757

Merged
Anilople merged 2 commits intoapolloconfig:masterfrom
nobodyiam:add-more-link
Jun 16, 2021
Merged

add More... link for known users#3757
Anilople merged 2 commits intoapolloconfig:masterfrom
nobodyiam:add-more-link

Conversation

@nobodyiam
Copy link
Copy Markdown
Member

What's the purpose of this PR

I think there are already enough known users shown in the front page, so it's better to show a more link instead of adding new users.

Brief changelog

  • add a More... link for known users table

Follow this checklist to help us incorporate your contribution quickly and easily:

  • Read the Contributing Guide before making this pull request.
  • Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
  • Write necessary unit tests to verify the code.
  • Run mvn clean test to make sure this pull request doesn't break anything.
  • Update the CHANGES log.

@codecov-commenter
Copy link
Copy Markdown

codecov-commenter commented Jun 13, 2021

Codecov Report

Merging #3757 (6946b80) into master (aef7d83) will increase coverage by 0.02%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff              @@
##             master    #3757      +/-   ##
============================================
+ Coverage     50.49%   50.51%   +0.02%     
+ Complexity     2395     2392       -3     
============================================
  Files           458      458              
  Lines         14472    14472              
  Branches       1467     1467              
============================================
+ Hits           7307     7310       +3     
  Misses         6659     6659              
+ Partials        506      503       -3     
Impacted Files Coverage Δ
...framework/apollo/openapi/entity/ConsumerAudit.java 42.42% <0.00%> (-6.07%) ⬇️
...rk/apollo/spring/property/SpringValueRegistry.java 83.33% <0.00%> (-5.56%) ⬇️
...mework/apollo/openapi/service/ConsumerService.java 47.57% <0.00%> (-1.95%) ⬇️
.../framework/apollo/spring/property/SpringValue.java 87.71% <0.00%> (-1.76%) ⬇️
.../apollo/internals/RemoteConfigLongPollService.java 77.10% <0.00%> (-0.61%) ⬇️
...ervice/service/ReleaseMessageServiceWithCache.java 87.05% <0.00%> (+1.17%) ⬆️
...ework/apollo/internals/RemoteConfigRepository.java 89.37% <0.00%> (+3.12%) ⬆️
...mework/apollo/portal/component/PortalSettings.java 65.62% <0.00%> (+7.81%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update aef7d83...6946b80. Read the comment docs.

@Anilople Anilople merged commit 6463904 into apolloconfig:master Jun 16, 2021
@github-actions github-actions Bot locked and limited conversation to collaborators Jun 16, 2021
@nobodyiam nobodyiam deleted the add-more-link branch June 17, 2021 00:13
@nobodyiam nobodyiam added this to the 1.9.0 milestone Jul 11, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants