Reduce bootstrap time in the situation with large properties#3816
Merged
nobodyiam merged 1 commit intoapolloconfig:masterfrom Jul 19, 2021
Merged
Conversation
|
CLA Assistant Lite bot All contributors have signed the CLA ✍️ ✅ |
Contributor
Author
|
I have read the CLA Document and I hereby sign the CLA |
389f967 to
04898e9
Compare
Codecov Report
@@ Coverage Diff @@
## master #3816 +/- ##
============================================
+ Coverage 49.93% 50.10% +0.16%
- Complexity 2442 2460 +18
============================================
Files 482 483 +1
Lines 14853 14891 +38
Branches 1507 1515 +8
============================================
+ Hits 7417 7461 +44
+ Misses 6914 6906 -8
- Partials 522 524 +2
Continue to review full report at Codecov.
|
04898e9 to
2e89f18
Compare
nobodyiam
reviewed
Jul 10, 2021
796d55f to
542951e
Compare
nobodyiam
reviewed
Jul 11, 2021
nobodyiam
reviewed
Jul 11, 2021
f262156 to
b37687c
Compare
b37687c to
9979023
Compare
nobodyiam
requested changes
Jul 17, 2021
Member
nobodyiam
left a comment
There was a problem hiding this comment.
Basically it looks good now except for some minor comments, thanks!
Member
|
Please also update the branch and solve the conflicts in |
nobodyiam
reviewed
Jul 17, 2021
9979023 to
c8e839d
Compare
Contributor
Author
Done. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What's the purpose of this PR
Reduce bootstrap time in the situation with large properties.
Use test method described in #3800, compare results:
Which issue(s) this PR fixes:
Fixes #3800
Brief changelog
Reduce bootstrap time in the situation with large properties.
Follow this checklist to help us incorporate your contribution quickly and easily:
mvn clean testto make sure this pull request doesn't break anything.CHANGESlog.