Skip to content

translation of "portal-how-to-enable-webhook-notification.md"#3847

Merged
JaredTan95 merged 12 commits intoapolloconfig:masterfrom
amartya314:lsh
Jul 28, 2021
Merged

translation of "portal-how-to-enable-webhook-notification.md"#3847
JaredTan95 merged 12 commits intoapolloconfig:masterfrom
amartya314:lsh

Conversation

@amartya314
Copy link
Copy Markdown
Contributor

@amartya314 amartya314 commented Jul 26, 2021

What's the purpose of this PR

translate "portal-how-to-enable-webhook-notification.md" into English.

Which issue(s) this PR fixes:

Fixes #3541

Brief changelog

XXXXX

Follow this checklist to help us incorporate your contribution quickly and easily:

  • Read the Contributing Guide before making this pull request.
  • Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
  • Write necessary unit tests to verify the code.
  • Run mvn clean test to make sure this pull request doesn't break anything.
  • Update the CHANGES log.

@github-actions
Copy link
Copy Markdown

github-actions Bot commented Jul 26, 2021

CLA Assistant Lite bot All contributors have signed the CLA ✍️ ✅

@amartya314
Copy link
Copy Markdown
Contributor Author

I have read the CLA Document and I hereby sign the CLA

@Anilople Anilople added the area/document Category issues or prs related to document. label Jul 26, 2021
@Anilople Anilople added this to the 1.9.0 milestone Jul 26, 2021
Comment thread docs/en/development/portal-how-to-enable-webhook-notification.md Outdated
Comment thread docs/en/development/portal-how-to-enable-webhook-notification.md Outdated
Copy link
Copy Markdown
Contributor

@Anilople Anilople left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Welcome! Thanks for contribution.

Please Update the CHANGES log In this PR.

Comment thread docs/en/development/portal-how-to-enable-webhook-notification.md Outdated
Comment thread docs/en/development/portal-how-to-enable-webhook-notification.md Outdated
@codecov-commenter
Copy link
Copy Markdown

codecov-commenter commented Jul 26, 2021

Codecov Report

Merging #3847 (3150c07) into master (a44e251) will increase coverage by 0.02%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff              @@
##             master    #3847      +/-   ##
============================================
+ Coverage     50.14%   50.16%   +0.02%     
+ Complexity     2468     2466       -2     
============================================
  Files           483      483              
  Lines         14921    14921              
  Branches       1520     1520              
============================================
+ Hits           7482     7485       +3     
+ Misses         6913     6909       -4     
- Partials        526      527       +1     
Impacted Files Coverage Δ
...rk/apollo/spring/property/SpringValueRegistry.java 83.33% <0.00%> (-5.56%) ⬇️
.../framework/apollo/spring/property/SpringValue.java 87.71% <0.00%> (-1.76%) ⬇️
...ervice/service/ReleaseMessageServiceWithCache.java 85.88% <0.00%> (-1.18%) ⬇️
.../apollo/internals/RemoteConfigLongPollService.java 78.31% <0.00%> (+1.20%) ⬆️
...mework/apollo/portal/component/PortalSettings.java 65.62% <0.00%> (+7.81%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a44e251...3150c07. Read the comment docs.

Anilople
Anilople previously approved these changes Jul 26, 2021
Anilople
Anilople previously approved these changes Jul 26, 2021
Copy link
Copy Markdown
Member

@nobodyiam nobodyiam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your contribution! Please see some suggestions below.

Comment thread docs/en/development/portal-how-to-enable-webhook-notification.md Outdated
Comment thread docs/en/development/portal-how-to-enable-webhook-notification.md Outdated
Comment thread docs/en/development/portal-how-to-enable-webhook-notification.md Outdated
Comment thread docs/en/development/portal-how-to-enable-webhook-notification.md Outdated
@amartya314
Copy link
Copy Markdown
Contributor Author

I have read the CLA Document and I hereby sign the CLA

@amartya314 amartya314 requested review from Anilople and nobodyiam July 27, 2021 01:38
@amartya666
Copy link
Copy Markdown
Contributor

I have read the CLA Document and I hereby sign the CLA

Copy link
Copy Markdown
Member

@nobodyiam nobodyiam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@nobodyiam
Copy link
Copy Markdown
Member

@JaredTan95 @Anilople Please help to review.

Copy link
Copy Markdown
Contributor

@Anilople Anilople left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Copy Markdown
Member

@JaredTan95 JaredTan95 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@JaredTan95 JaredTan95 merged commit 8ccbbe4 into apolloconfig:master Jul 28, 2021
@github-actions github-actions Bot locked and limited conversation to collaborators Jul 28, 2021
@Anilople Anilople added good first issue good first issue Good for beginners and removed good first issue good first issue Good for beginners labels Jul 30, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

area/document Category issues or prs related to document.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Translate Chinese document into English

6 participants