ASoC: amd: acp: Fix leak in acp_pci_probe()

Dan Carpenter · broonie · commit 02026aabaa82 · 2025-03-16T23:33:41.000Z
There needs to be some cleanup on this error path. We can't just return directly. Fixes: aaf7a66 ("ASoC: amd: acp: Add new interrupt handle callbacks in acp_common_hw_ops") Signed-off-by: Dan Carpenter <dan.carpenter@linaro.org> Link: https://patch.msgid.link/3dad80cb-e177-45aa-97ac-df9c98a47d94@stanley.mountain Signed-off-by: Mark Brown <broonie@kernel.org>
diff --git a/sound/soc/amd/acp/acp-pci.c b/sound/soc/amd/acp/acp-pci.c
@@ -183,7 +183,7 @@ static int acp_pci_probe(struct pci_dev *pci, const struct pci_device_id *pci_id
 			       IRQF_SHARED, "ACP_I2S_IRQ", chip);
 	if (ret) {
 		dev_err(&pci->dev, "ACP I2S IRQ request failed %d\n", ret);
-		return ret;
+		goto de_init;
 	}
 
 	check_acp_config(pci, chip);

Original file line number	Diff line number	Diff line change
`@@ -183,7 +183,7 @@ static int acp_pci_probe(struct pci_dev pci, const struct pci_device_id pci_id`
`183`	`183`	`IRQF_SHARED, "ACP_I2S_IRQ", chip);`
`184`	`184`	`if (ret) {`
`185`	`185`	`dev_err(&pci->dev, "ACP I2S IRQ request failed %d\n", ret);`
`186`		`- return ret;`
	`186`	`+ goto de_init;`
`187`	`187`	`}`
`188`	`188`
`189`	`189`	`check_acp_config(pci, chip);`